Hi, Is the following sentence OK:
"How long have you worked as a teacher for?"
Hi, Ahmed—Yes, that sentence is correct. Compare: "For how long have you worked as a teacher?" However, the "for" is unnecessary. You can simply ask, "How long have you worked as a teacher?"