Hi! Can anyone tell me whether or not this sentence is grammatically correct?

My science teacher was teaching there a long time now.

Shouldn't it be " My science teacher has been teaching there for a long time."?

Original Post
Kyle posted:

Can anyone tell me whether or not this sentence is grammatically correct?

My science teacher was teaching there a long time now.

Shouldn't it be " My science teacher has been teaching there for a long time."?

Hi, Kyle,

No, that sentence isn't correct. The adverbial of duration, "(for) a long time now," is incompatible with the past tense. One possible revision is the one you've suggested. Here is another possible revision, which gives a different meaning. Which you should choose depends on whether the teacher still teaches there.

  • My science teacher was teaching there (for) a long time.
  • My science teacher taught there (for) a long time.

Add Reply

Likes (0)
×
×
×
×